[Refactor] Stores now return Arc for construction #989
Conversation
allada
changed the title
There was a problem hiding this comment.
fyi: @adam-singer
+@zbirenbaum
note: This PR is pending the memory store PR to land first.
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-lre-cc, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable (waiting on @zbirenbaum)
There was a problem hiding this comment.
Reviewed 11 of 17 files at r1, 18 of 18 files at r2.
Reviewable status: 0 of 1 LGTMs obtained (waiting on @zbirenbaum)
allada
force-pushed
the
all-stores-now-use-arc
branch
from
18d776c to
68a4fac
Compare
There was a problem hiding this comment.
Reviewed 11 of 11 files at r3, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Publish image, Publish nativelink-worker-lre-cc, pre-commit-checks (waiting on @zbirenbaum)
There was a problem hiding this comment.
Reviewed 18 of 18 files at r2, 11 of 11 files at r3, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and pending CI: Publish image, Publish nativelink-worker-lre-cc, pre-commit-checks
We implicitly use all stores as Arc's anyway, so this PR just makes it easier for stores to grab a Weak to self for some specific cases.
allada
force-pushed
the
all-stores-now-use-arc
branch
from
68a4fac to
9bc770c
Compare
There was a problem hiding this comment.
Reviewed 1 of 18 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained
We implicitly use all stores as Arc's anyway, so this PR just
makes it easier for stores to grab a Weak to self for some
specific cases.
This change is