-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributed scan run #62
Conversation
if (caller.equals("runScan")) { | ||
TraceableASTRunStepBuilder.setScanId(workspace.act(new RunScript(listener, scriptPath, args, caller))); | ||
} else if (caller.equals("abortScan")) { | ||
workspace.act(new RunScript(listener, scriptPath, args, caller)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
common out this line
execScript.append(" ").append(args[i]); | ||
else execScript.append(" ''"); | ||
if (caller.equals("runScan")) { | ||
TraceableASTRunStepBuilder.setScanId(workspace.act(new RunScript(listener, scriptPath, args, caller))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this scan Id getting set , where are we returning the extracted scanId in RunScript?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RunScript
after processing, returns the scanId to this function. Which is been set using setScanId
method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you point in RunScript where are we returning the scanId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary:
Replaced the following steps using a FileCallable:
Replaced the following steps with Launcher:
These ensure that all the processes take place at the remote agent, where the workspace is present.