Distributed scan run #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souvik-karfa
requested review from
samarth-gupta-traceable and
dhruv-singhal-github
as code owners
| if (caller.equals("runScan")) { | ||
| TraceableASTRunStepBuilder.setScanId(workspace.act(new RunScript(listener, scriptPath, args, caller))); | ||
| } else if (caller.equals("abortScan")) { | ||
| workspace.act(new RunScript(listener, scriptPath, args, caller)); |
There was a problem hiding this comment.
common out this line
| execScript.append(" ").append(args[i]); | ||
| else execScript.append(" ''"); | ||
| if (caller.equals("runScan")) { | ||
| TraceableASTRunStepBuilder.setScanId(workspace.act(new RunScript(listener, scriptPath, args, caller))); |
There was a problem hiding this comment.
how is this scan Id getting set , where are we returning the extracted scanId in RunScript?
There was a problem hiding this comment.
The RunScript after processing, returns the scanId to this function. Which is been set using setScanId method.
There was a problem hiding this comment.
can you point in RunScript where are we returning the scanId
There was a problem hiding this comment.
In the invoke method of RunScript, we are returning this. We are setting this in the logOutputmethod.
dhruv-singhal-github
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Replaced the following steps using a FileCallable:
Replaced the following steps with Launcher:
These ensure that all the processes take place at the remote agent, where the workspace is present.