Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "DataFrames" to "1.1" #87

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 8, 2021

This pull request changes the compat entry for the DataFrames package from 0.21, 0.22 to 0.21, 0.22, 1.1.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@khosravipasha khosravipasha force-pushed the compathelper/new_version/2021-05-08-00-38-17-434-241645309 branch from 28b8428 to 02db235 Compare May 8, 2021 00:38
@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #87 (61cd0e5) into master (36d8fe5) will decrease coverage by 1.39%.
The diff coverage is n/a.

❗ Current head 61cd0e5 differs from pull request most recent head 4258850. Consider uploading reports for the commit 4258850 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   88.33%   86.94%   -1.40%     
==========================================
  Files          30       30              
  Lines        2590     2589       -1     
==========================================
- Hits         2288     2251      -37     
- Misses        302      338      +36     
Impacted Files Coverage Δ
src/queries/satisfies.jl 62.24% <ø> (-14.29%) ⬇️
src/transformations.jl 95.81% <ø> (-0.33%) ⬇️
src/Utils/cubitvector.jl 33.33% <0.00%> (-16.67%) ⬇️
src/queries/satisfies_flow.jl 47.18% <0.00%> (-4.77%) ⬇️
src/Utils/data.jl 81.76% <0.00%> (-3.32%) ⬇️
src/bit_circuit.jl 81.30% <0.00%> (-1.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36d8fe5...4258850. Read the comment docs.

@khosravipasha
Copy link
Collaborator

Fails for the following case, need to double check why that is happening.

circuit(false, true, true) # sun is false, rain is true, rainbow is true

Stacktrace:
[1] error(::String) at ./error.jl:33
[2] execute_block(::Module, ::String) at /home/runner/.julia/packages/Literate/kB2Gm/src/Literate.jl:720
[3] execute_markdown!(::Base.GenericIOBuffer{Array{UInt8,1}}, ::Module, ::String, ::String) at /home/runner/.julia/packages/Literate/kB2Gm/src/Literate.jl:479
[4] markdown(::String, ::String; config::Dict{Any,Any}, kwargs::Base.Iterators.Pairs{Symbol,Any,NTuple{4,Symbol},NamedTuple{(:documenter, :credit, :execute, :preprocess),Tuple{Bool,Bool,Bool,Base.var"#62#63"{typeof(hide_plots),typeof(replace_includes)}}}}) at /home/runner/.julia/packages/Literate/kB2Gm/src/Literate.jl:463
[5] top-level scope at /home/runner/work/LogicCircuits.jl/LogicCircuits.jl/docs/make.jl:39
[6] include(::Function, ::Module, ::String) at ./Base.jl:380
[7] include(::Module, ::String) at ./Base.jl:368
[8] exec_options(::Base.JLOptions) at ./client.jl:296
[9] _start() at ./client.jl:506
in expression starting at /home/runner/work/LogicCircuits.jl/LogicCircuits.jl/docs/make.jl:39
Error: Process completed with exit code 1.

@khosravipasha khosravipasha self-assigned this May 8, 2021
@khosravipasha khosravipasha merged commit 48359a7 into master Jun 16, 2021
@khosravipasha khosravipasha deleted the compathelper/new_version/2021-05-08-00-38-17-434-241645309 branch July 16, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant