[WIP] feat: publishing of completed documents #11
Conversation
yehjxraymond
changed the title
yehjxraymond
changed the title
isaackps
force-pushed
the
feat/publishDocument
branch
from
4baf4ad to
6c15aa0
Compare
yehjxraymond
force-pushed
the
feat/publishDocument
branch
from
3e0edea to
0692f02
Compare
yehjxraymond
force-pushed
the
feat/publishDocument
branch
from
cf08adf to
d01fccb
Compare
|
|
||
| return ( | ||
| <> | ||
| {show && ( |
There was a problem hiding this comment.
Don't have to pass a show props in if it's handled by the parent
There was a problem hiding this comment.
Can remove the fragment while at it
| return ( | ||
| <> | ||
| {show && ( | ||
| <ModalDialog show={show} close={closeDeleteModal}> |
There was a problem hiding this comment.
Can remove show props. See comments below on the ModalDialog.
| it("should not display anything on initial", () => { | ||
| render(<DeleteModal deleteForm={() => {}} show={false} closeDeleteModal={() => {}} />); | ||
|
|
||
| expect(screen.queryAllByText("Delete Form")).toHaveLength(0); | ||
| }); |
There was a problem hiding this comment.
Can remove when we remove show
There was a problem hiding this comment.
still needs it for the part to show the component or not.
| }) => { | ||
| return ( | ||
| <> | ||
| {show && ( |
There was a problem hiding this comment.
Same thing, can remove show here as well. Managed by whoever calls the dialog
There was a problem hiding this comment.
erm because we using the useLockBodyScroll, if the component is being rendered but not shown on screen, the body will be locked, so still need the show props in here, but can remove in the modalDialog.
| onFormSubmit, | ||
| }) => { | ||
| return ( | ||
| <> |
There was a problem hiding this comment.
You also like to put fragments everywhere lol
| return (hasError = true); | ||
| } | ||
| setFormError(ajv.errors); | ||
| return (hasError = false); |
There was a problem hiding this comment.
Consider a loop that runs twice.
The first run, return errors
The second run, returns no errors
Should the final hasError be true or false?
In this case it seeemed like if the last loop has no error, then it will return no error.
There was a problem hiding this comment.
hmmm ok will edit it to cater to the error in any run of the loop
| const validateCurrentForm = (): boolean => { | ||
| const ajv = new Ajv(); | ||
| let hasError = false; | ||
| forms.forEach((form) => { |
There was a problem hiding this comment.
Why not just run for the current form?
There was a problem hiding this comment.
hmm ok will change to just the current form
| const onBackToFormSelection = (): void => { | ||
| removeCurrentForm(); | ||
| }; |
There was a problem hiding this comment.
can remove, it does nothing more than just removeCurrentForm
| <SvgIconXCircle /> | ||
| </SvgIcon> | ||
| <div className="text-red text-xl text-center"> | ||
| This form has errors. Please fix the errors and submit again. |
There was a problem hiding this comment.
Don't you want to spell the errors out?
There was a problem hiding this comment.
yup, will display a list of errors upon validation
| <> | ||
| {show && ( |
Publishing of documents on the blockchain
Done
Not Done
Changes to core
jest-environment-jsdom-sixteento test environment to preventTypeError: MutationObserver is not a constructorerror (waitFor error "MutationObserver is not a constructor" with latest version testing-library/dom-testing-library#477)