feat: verify networkselector #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for tradetrust-mainnet ready! 🔨 Explore the source changes: 25e4484 🔍 Inspect the deploy log: https://app.netlify.com/sites/tradetrust-mainnet/deploys/621c7bbfa8c0bb0007925a77 😎 Browse the preview: https://deploy-preview-550--tradetrust-mainnet.netlify.app/ |
|
✔️ Deploy Preview for tradetrust-mainnet ready! 🔨 Explore the source changes: 11bc0ee 🔍 Inspect the deploy log: https://app.netlify.com/sites/tradetrust-mainnet/deploys/622b025afd3a5600081afeba 😎 Browse the preview: https://deploy-preview-550--tradetrust-mainnet.netlify.app |
osslgtm
commented
Feb 28, 2022
superical
reviewed
Mar 1, 2022
isaackps
requested changes
Mar 9, 2022
osslgtm
force-pushed
the
feat/verify-networkselector
branch
2 times, most recently
from
993e256 to
98011d7
Compare
osslgtm
force-pushed
the
feat/verify-networkselector
branch
from
98011d7 to
7e51b5a
Compare
isaackps
reviewed
Mar 10, 2022
isaackps
reviewed
Mar 10, 2022
isaackps
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addition of Network Selector to Verify Page, and removing placement of network selector on top bar
Changes
Checks if uploaded file can be parsed by JSON Parser - outputs error if can't be parsed
Checking on OA Document, to see if NetworkSelected matches document's network field.
Tests for the above
Issues
Move Network Selector to Verify Page + UI Updates
https://www.pivotaltracker.com/story/show/181134373
Remove NetworkSelector from AppContainer
https://www.pivotaltracker.com/story/show/181134371