Skip to content

Commit

Permalink
fix: add node 20 support
Browse files Browse the repository at this point in the history
  • Loading branch information
nghaninn committed Nov 10, 2024
1 parent 4e4b2f8 commit e287c55
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 10 deletions.
22 changes: 14 additions & 8 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,29 @@ name: "Tests"

jobs:
run-tests:
name: Run Tests
name: Run Tests Node ${{ matrix.node }}
runs-on: ubuntu-latest
strategy:
matrix:
node: [ 18, 20 ]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: ${{ matrix.node }}
- run: npm ci
- run: npm run test:ci

test-build:
name: Test Build
name: Test Build Node ${{ matrix.node }}
runs-on: ubuntu-latest
strategy:
matrix:
node: [ 18, 20 ]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: ${{ matrix.node }}
- run: npm ci
- run: npm run build
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,6 @@
},
"snyk": true,
"engines": {
"node": "18.x"
"node": ">=18.x"
}
}

0 comments on commit e287c55

Please sign in to comment.