Add 3rd argument to getattr #727
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexECX
force-pushed
the
Add-3rd-argument-to-getattr
branch
from
39c739e
to
add814a
Compare
AlexECX
force-pushed
the
Add-3rd-argument-to-getattr
branch
from
add814a
to
f2c6a60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The
getattrfunction is missing the optional 3rd, 'failsafe', argument, it also does not raise an AttributeError when the accessed attribute is not present. This PR takes care of both issues.Note: The proposed new
getattrfunction takes extra steps to retrieve the name of the accessed object when building theAttributeErrormessage. A more generic message could be used instead, although it would make it less meaningful.Related issue number
Related to #633 .
PR Checklist