Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get toolkit_id and compare name instead of id #1333

Merged
merged 1 commit into from
Oct 10, 2023
Merged

get toolkit_id and compare name instead of id #1333

merged 1 commit into from
Oct 10, 2023

Conversation

masquerade-06
Copy link
Contributor

Description

the types where wrong so the query was failing and also the comparison was done between the id and name which was also changed

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My pull request is atomic and focuses on a single change.
  • I have read the contributing guide and my code conforms to the guidelines.
  • I have documented my changes clearly and comprehensively.
  • I have added the required tests.

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Fluder-Paradyne Fluder-Paradyne merged commit 9e5e729 into TransformerOptimus:main Oct 10, 2023
5 checks passed
@Fluder-Paradyne Fluder-Paradyne mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fluder-Paradyne Fluder-Paradyne Fluder-Paradyne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masquerade-06 @CLAassistant @Fluder-Paradyne