Openai error handling for ratelimit, timeout and try again errors(fix #1255) #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le and its tests - Adds test for rate limit error handling in the llms/openai module - Adds error handling for rate limit error in the llms/openai module - Refactors code in llms/openai module to be readable and modular
…and its test - Adds test for timeout error handling in chat_completion in llms/openai module - Adds error handling for openai's timeout error in chat_completion in llms/openai module
…e and its test - Adds test for openai's try again error handling in chat_completion in llms/openai module - Adds error handling for openai's try again error in chat_completion in llms/openai module
…y attempts are exausted
|
|
aleric-cusher
force-pushed
the
openai_error_handling
branch
from
9e8c7c2
to
b6d0720
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1361 +/- ##
==========================================
+ Coverage 58.66% 58.73% +0.06%
==========================================
Files 230 230
Lines 11188 11202 +14
Branches 1206 1209 +3
==========================================
+ Hits 6563 6579 +16
+ Misses 4289 4286 -3
- Partials 336 337 +1
☔ View full report in Codecov by Sentry. |
luciferlinx101
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With these changes the agent won't stop if a ratelimit error or timeout error or try again error is hit from the openai library, it will try again.
Related Issues
#1255
Solution and Design
The agent will attempt to wait 5 times with an exponential backoff strategy and try again, it will wait for a minimum of 30 seconds and max of 300 seconds.
If after 5 attempts the api call still fails it will return the error.
Test Plan
The code is tested by mocking the api calls to openai and having it return the errors mentioned above and checking if the function has called the api specified number of times and it returns the expected error as a dictionary object.
To reduce the time taken to test, the tencity library's wait_random_exponential function is mocked to only use 0.1 seconds
Type of change
Checklist