fixNFTokenBrokerAccept #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangell7
force-pushed
the
xls20brokerfix
branch
7 times, most recently
from
61888ec to
2664f83
Compare
dangell7
force-pushed
the
xls20brokerfix
branch
2 times, most recently
from
a256a49 to
4141563
Compare
update: error response fixup test error [FOLD] fix failing tests nit: comments clang-format clang-format refactor tests update comment rename xrpl fix fixup
dangell7
force-pushed
the
xls20brokerfix
branch
from
ee92f73 to
b7e9f3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Currently with NFTs using broker mode if the sell offer contains a destination and that destination is the buyer account, anyone can broker the transaction.
It is also true that if a buy offer contains a destination and that destination is the seller account, anyone can broker the transaction.
Imo this is not ideal and is misleading to everyone.
The comments in the code are;
This is misleading because the broker is the account submitting the transaction. Its anyone. Again, if the buyer specified a destination and that destination is the seller, anyone can settle the tx. I don't think that makes sense. Why even have that? If anyone can settle the tx then there is no point in having this arithmetic I think.
I believe the point was; If you set a destination, that destination needs to be the person settling the transaction.
Context of Change
The changes made now force the broker to be the destination if they want to settle. If the buyer is the destination, then the buyer must accept the sell offer, as you cannot broker your own offers.
If users want their offers open to the public then not setting a destination would be the recommended way. Inversely, if users want to limit who can settle the offers, then they would set a destination.
There is also a discussion issue here:
Type of Change
Test Plan
I also added a test function to show one of the more recent issues. There are 2 things tested.