-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UMLS coverage #50
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09aa9e2
to
2028daa
Compare
048012d
to
5b63ffa
Compare
fa7fb28
to
2e9160b
Compare
2b42e60
to
5d2cdb8
Compare
cbizon
requested changes
Oct 4, 2022
cbizon
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will implement the plan in TranslatorSRI/NodeNormalization#119 (comment) to (1) create a compendium of UMLS IDs, labels and types for UMLS IDs that weren't included in other compendia, and (2) produce a report that will help us find sections of the UMLS that should be incorporated into Babel in other compendia.
It also fixes a minor bug in which "UMLS" was not listed as a prerequisite for "chemical", which caused "chemical" in some cases to run before the UMLS ids, labels and synonyms had been produced.