bye-bye sprintf #632
Merged
bye-bye sprintf #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squash into dade6dd to remove Python style floats: * e73a895 tm-master.nmp * a1925a2 Waypoint::str
fix warnings reported by clang 17.0.6
|
Ready to rock. |
|
This will be used for tonight's site update. The common datacheck version in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #585.
Removes
sprintfcompletely.d4a8716 silences a few warnings from the new clang version on noreaster.
It's possible that XCode may still generate warnings for other functions deprecated for similar reasons, E.G.
styrcpyused in the subgraph CSV routines.Feel free to open another issue if this is the case.
"Python style floats", with a
.0at the end of integral values, are being phased out.Cleaner simpler code, I'm not worried about keeping things diffable to siteupdate.py now that it's deprecated, and these don't affect anything in practice anyway.
Waypoint::str()No instances in nmpfps.log, so no problem.
No diffs before <-> after.
No instances in datacheckfps.log, so no problem.
Meanwhile, the one affecting the
waypointssql table was phased out in #623 & phased back in in #628.*shrug* Eh, it keeps the .sql files diffable?
Hm. I expected more of a difference when writing to /dev/null.
There's lots of copying, comparing & sorting strings, and checking set membership.
What -- lab2 & lab3 are worse now? This looks like the disk access bottleneck variability that made me start writing to /dev/null. So, I deleted mountains of logs stats & graphs left over from previous runs and tried again.
"After" mostly improves on "before" this time around, but we get there by way of stuff performing worse. Go figure.
This may be one of those rare cases when the /dev/null chart is more informative.
FreeBSD improves tons. Disk access wasn't the bottleneck; it was
sprintf.Let's zoom in.
Everything scales up well, even if bsdlab lags behind the others.
Lab3 is the fastest on its hardware now, and lab2 is the fastest overall.