Sub endpoint #1
Open
Sub endpoint #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrants
reviewed
Aug 25, 2017
|
|
||
| <br /> | ||
|
|
||
| ## Publisher Header and Footer |
There was a problem hiding this comment.
My impression is that this documentation would be implementation details. There's some overlap with what would be in the "Publisher Field Guide". The other pieces are implementation details. This part is obviously important, but I'm not sure if it is really implementation details.
ferrants
reviewed
Aug 25, 2017
|
|
||
| <br /> | ||
|
|
||
| ## Best practices |
There was a problem hiding this comment.
We have a includes/best-practices.md you could include here so you don't need to duplicate on more pages
|
This is all in the wrong repo. Docs should be here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for initial review--not final!