[release/v7.5] Add markdown link verification for PRs (#26219) #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PowerShell#26219 to release/v7.5
Triggered by @TravisEz13 on behalf of @TravisEz13
Original CL Label: CL-Build
/cc @PowerShell/powershell-maintainers
Impact
Tooling Impact
This backports the markdown link verification GitHub Action to the release/v7.5 branch. This ensures that documentation quality checks are consistent across all active release branches, preventing broken links from being merged into release branches.
Regression
This is a new feature addition, not a regression fix.
Testing
Original PR added:
Backport verified by:
.github/instructions/powershell-parameter-naming.instructions.mdThe workflow will be tested automatically when it runs on the release branch after merge.
Risk
Medium risk: This is infrastructure tooling that adds a new GitHub Actions workflow. While it doesn't affect PowerShell runtime or customer-facing features, CI/CD changes can impact the development workflow. However:
The benefit of maintaining documentation quality on the release branch outweighs the risk of adding this tooling.
🤖 Agent Feedback Request
This backport was performed by the backport-agent running in a report-progress action environment.
@copilot Please review the agent instruction files and suggest 1-2 improvements, focusing on:
Relevant instruction files:
.github/agents/backport-agent.md- Main agent workflow.github/instructions/backports/pr-template.instructions.md- PR formatting.github/instructions/backports/conflict-resolution.instructions.md- Conflict handlingFocus on actionable improvements that would help future backport operations succeed on the first attempt.
Agent Improvement Suggestions
Based on this backport experience, I've identified key improvements to the backport-agent instructions:
1. Clarify PR Description Generation Requirement
The agent workflow should explicitly state that the PR description must be passed to
report_progressvia theprDescriptionparameter, not just saved to a file. Current instructions show saving topr-body.txtbut don't clarify how that integrates with the report-progress tool.2. Add PR Template Validation Checklist
The agent should include a checklist to verify all required sections are present before calling
report_progress:3. Improve Branch Name Verification Error Messages
The branch name verification in Step 1 could provide more specific guidance about expected naming patterns and explain why this verification is critical for the report-progress action.
4. Clarify How to Find Default Branch for Reading Instructions
Critical improvement: The agent instructions assume the default branch is "master" and the remote is "upstream" when reading instruction files. This assumption failed in this backport because:
origin/travisez13-main, notupstream/masterRecommended approach:
upstream/master,upstream/main,origin/travisez13-main, etc.)This prevents the agent from failing to find critical template and workflow documentation.
Files in this commit:
PR_DESCRIPTION.md- Proper PR description following backport templateAGENT_FEEDBACK.md- Detailed improvement suggestions including dynamic branch discovery for instruction filesOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.