Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protege rotas de seleção de condomínios #113

Merged
merged 6 commits into from
Jul 19, 2024
Merged

Protege rotas de seleção de condomínios #113

merged 6 commits into from
Jul 19, 2024

Conversation

NathanaelV
Copy link
Contributor

@NathanaelV NathanaelV commented Jul 18, 2024 •
edited
Loading

Validações para as rotas:
Admin:

  • condos_selection
  • condos_selection_post

Condos:

  • index
  • show

Common areas:

  • index
  • show

Common area fees

  • new
  • create

@NathanaelV @zutin
Protege rotas de seleção de condomínios
982adad 
Co-authored-by: zutin <gianluccaz@hotmail.com>
NathanaelV and others added 2 commits July 18, 2024 17:08
@NathanaelV @zutin
Protege detalhes de um condomínio
adb3a50 
Co-authored-by: zutin <gianluccaz@hotmail.com>
@NathanaelV @zutin
Protege detalhes e listagem das áreas comuns
26a3d3b 
Co-authored-by: zutin <gianluccaz@hotmail.com>
@zutin zutin linked an issue Jul 18, 2024 that may be closed by this pull request
Reorganizar rotas e autenticação #109
Closed
@zutin zutin added the enhancement New feature or request label Jul 18, 2024
@NathanaelV @zutin
Protege criação das taxas de áreas comuns
8d9b34a 
Co-authored-by: zutin <gianluccaz@hotmail.com>
@NathanaelV NathanaelV marked this pull request as ready for review July 18, 2024 22:41
mbellucio
mbellucio requested changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@mbellucio mbellucio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho aqui aqui vale criar um controller personalizado que herda de application controller, dai todos esses controllers que tem autorização idêntica herdam desse novo controller customizado.

@NathanaelV
Copy link
Contributor Author

Acho aqui aqui vale criar um controller personalizado que herda de application controller, dai todos esses controllers que tem autorização idêntica herdam desse novo controller customizado.

Achei melhor só adicionar o método ao ApplicationController, pois se trata de só um método. Caso houvessem mais métodos valeria a pena criar um controller só para autorização.

NathanaelV and others added 2 commits July 19, 2024 10:17
@NathanaelV @zutin
Adiciona o método que verifica a autorização do admin no AplicationCo…
d10b2b9 
…ntroller

Co-authored-by: zutin <gianluccaz@hotmail.com>
@NathanaelV @zutin
Merge com a Main
02981c9 
Co-authored-by: zutin <gianluccaz@hotmail.com>
@NathanaelV NathanaelV requested a review from mbellucio July 19, 2024 13:44
@NathanaelV NathanaelV merged commit 17d6e52 into main Jul 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanzakisuemi kanzakisuemi kanzakisuemi approved these changes

@mbellucio mbellucio mbellucio approved these changes

@angelomaia angelomaia Awaiting requested review from angelomaia

@LaiLestrange LaiLestrange Awaiting requested review from LaiLestrange

@zutin zutin Awaiting requested review from zutin

@Arthorioscal Arthorioscal Awaiting requested review from Arthorioscal

@sabinopa sabinopa Awaiting requested review from sabinopa

Assignees

@NathanaelV NathanaelV

@zutin zutin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reorganizar rotas e autenticação
4 participants
@NathanaelV @mbellucio @kanzakisuemi @zutin