Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atualização do cálculo de fatura #90

Merged
merged 14 commits into from
Jul 18, 2024
Merged

Conversation

angelomaia
Copy link
Contributor

@angelomaia angelomaia commented Jul 16, 2024

Finaliza critérios para calcular valor total da fatura.

O que foi feito:

  • Adiciona cobranças avulsas (singe_charges) ao cálculo
  • Ignora taxas, contas e cobranças canceladas (.canceled?)
  • Correção de lógica de recorrencia no calculo de taxas condominiais (base_fee.recurrence)
  • Adiciona taxas limitadas (base_fee.limited?) ao cálculo
  • Adiciona aluguel (rent_fee) ao cálculo

O que vem pela frente:
Listar os detalhes de cada conta dentro da fatura.

Co-authored-by: Angelo Maia <request.angelo@gmail.com>
@angelomaia angelomaia added the enhancement New feature or request label Jul 16, 2024
@angelomaia angelomaia linked an issue Jul 16, 2024 that may be closed by this pull request
sabinopa and others added 9 commits July 16, 2024 16:37
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
Co-authored-by: Angelo Maia <angelomaia@users.noreply.github.com>
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
@sabinopa sabinopa marked this pull request as ready for review July 18, 2024 13:40
Copy link
Contributor

@LaiLestrange LaiLestrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parabens por essa PR pessoal, é a funcionalidade principal da nossa aplicação, e deu pra ver que vocês amarraram tudo mt bem, vi também que vocês deram uma melhorada no fluxo de alguns testes e testaram bem as novas funcionalidades... enfim, vou deixar meu aprovado aqui! 🚀

Copy link
Contributor

@mbellucio mbellucio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arquivos bem organisados, adição de mais testes em bill calculator para cobrir as validações e lógicas de filtragem implementadas bem enxutas e eficientes, ao meu ver. Aprovado.

Copy link
Contributor

@zutin zutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parece tudo certo, as correções na lógica fazem sentido, senti falta de um teste pra garantir que o counter está funcionando e que a base_fee será considerada paid corretamente com o método.

app/models/base_fee.rb Show resolved Hide resolved
app/models/base_fee_calculator.rb Show resolved Hide resolved
sabinopa and others added 2 commits July 18, 2024 15:03
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
Copy link
Contributor

@zutin zutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprovando após alterações. Bom trabalho pessoal! 👏

@angelomaia angelomaia merged commit 5d5a038 into main Jul 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atualizar cálculo da fatura
6 participants