-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atualização do cálculo de fatura #90
Conversation
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
Co-authored-by: Angelo Maia <angelomaia@users.noreply.github.com>
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parabens por essa PR pessoal, é a funcionalidade principal da nossa aplicação, e deu pra ver que vocês amarraram tudo mt bem, vi também que vocês deram uma melhorada no fluxo de alguns testes e testaram bem as novas funcionalidades... enfim, vou deixar meu aprovado aqui! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arquivos bem organisados, adição de mais testes em bill calculator para cobrir as validações e lógicas de filtragem implementadas bem enxutas e eficientes, ao meu ver. Aprovado.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parece tudo certo, as correções na lógica fazem sentido, senti falta de um teste pra garantir que o counter está funcionando e que a base_fee será considerada paid
corretamente com o método.
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
Co-authored-by: Angelo Maia <request.angelo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aprovando após alterações. Bom trabalho pessoal! 👏
Finaliza critérios para calcular valor total da fatura.
O que foi feito:
singe_charges
) ao cálculo.canceled?
)base_fee.recurrence
)base_fee.limited?
) ao cálculorent_fee
) ao cálculoO que vem pela frente:
Listar os detalhes de cada conta dentro da fatura.