Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refatora atributos do convites #52

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Conversation

Luckvc
Copy link
Contributor

@Luckvc Luckvc commented Jan 30, 2024

Resolve #51

Alcançado nesse PR

Adiciona o campo de mensagem ao convite e adicionamos a passagem do email como hiddenfield para validação do mesmo quando o usuário convidado entra na plataforma.
Refatora os dados de retorno da api de convites, tirando o created_at e o expiration_days e inserindo o expiration_date.

  • Card de envio de convite
    image

  • Card do convite enviado
    image

  • Retorno da API
    image

Luckvc and others added 3 commits January 30, 2024 11:41
Retira created_at e expiration_days
Adiciona expiration_date

Co-authored-by: Lucas Aguilar <lucasaguilar835@gmail.com>
Co-authored-by: Lucas Aguilar <lucasaguilar835@gmail.com>
@Luckvc
Copy link
Contributor Author

Luckvc commented Jan 30, 2024

A gente ainda está na dúvida entre PR com valor e PR muito pequeno, um feedback sobre esse PR seria valioso.

@oLucasAguilar oLucasAguilar linked an issue Jan 30, 2024 that may be closed by this pull request
4 tasks
@OtavioLins
Copy link

A gente ainda está na dúvida entre PR com valor e PR muito pequeno, um feedback sobre esse PR seria valioso.

Esse PR está ok. Ele é pequeno, sim, mas ele resolve um objetivo claro e específico, que é completar os atributos de mensagem e fazer as refatorações necessárias em testes para isso :)

Co-authored-by: Lucas Aguilar <lucasaguilar835@gmail.com>
Copy link
Contributor

@paulohenrique-gh paulohenrique-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bom trabalho, pessoal. Os novos atributos deixaram o convite mais completo e vão ajudar nos próximos passos. 🚀

@Luckvc Luckvc changed the title Refactor/atributos do convite Refatora atributos do convites Jan 31, 2024
@Luckvc Luckvc merged commit 2a602dd into main Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Convite] Refatora dados do convite
4 participants