-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/adiciona user role a tarefa #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
…rrige testes Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
decoporteira
requested review from
akaninja,
valerialrc,
oLucasAguilar,
MoisesssDev,
fredericomozzato,
adoniranfranceh,
joaorsalmeida and
OtavioLins
February 6, 2024 14:37
…es para essa função. Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
…re/adiciona-user-role-a-tarefa
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
…ler e remove seu respectivo teste. Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
…or refatoração de código.
…or refatoração de código. Co-authored-by: Adoniran França <adoniranfranca@gmail.com>
…naDev/td11-cola-bora into feature/adiciona-user-role-a-tarefa
joaorsalmeida
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aprovado! Mas fiz um comentário de um ajuste que pode melhorar.
oLucasAguilar
approved these changes
Feb 6, 2024
fredericomozzato
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sugeri algumas mudanças, mas acho que nada que impeça o código de ser mergeado!
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
…re/adiciona-user-role-a-tarefa
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
…an_edit_task Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
…de Tasks. Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alcançamos com essa PR
Essa PR resolve #79
Adiciona a relação de
UserRole
comTask
, desse modo permitimos que uma tarefa seja criada por qualquer colaborador do projeto.Adiciona testes para validar que o líder e o administrador de um projeto possam editar qualquer tarefa dentro do projeto.
A implementação foi baseada no fluxo de
Mettings
em relação ao colaborador.