Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/adiciona user role a tarefa #80

Merged
merged 19 commits into from
Feb 7, 2024

Conversation

decoporteira
Copy link
Contributor

Alcançamos com essa PR

Essa PR resolve #79

  • Adiciona a relação de UserRole com Task, desse modo permitimos que uma tarefa seja criada por qualquer colaborador do projeto.

  • Adiciona testes para validar que o líder e o administrador de um projeto possam editar qualquer tarefa dentro do projeto.

A implementação foi baseada no fluxo de Mettings em relação ao colaborador.

decoporteira and others added 2 commits February 5, 2024 17:59
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
…rrige testes

Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
decoporteira and others added 5 commits February 6, 2024 15:18
…es para essa função.

Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
…ler e remove seu respectivo teste.

Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
decoporteira and others added 2 commits February 6, 2024 16:35
…or refatoração de código.

Co-authored-by: Adoniran França <adoniranfranca@gmail.com>
…naDev/td11-cola-bora into feature/adiciona-user-role-a-tarefa
Copy link
Contributor

@joaorsalmeida joaorsalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprovado! Mas fiz um comentário de um ajuste que pode melhorar.

app/models/task.rb Show resolved Hide resolved
app/models/user.rb Outdated Show resolved Hide resolved
spec/factories/tasks.rb Outdated Show resolved Hide resolved
app/controllers/tasks_controller.rb Outdated Show resolved Hide resolved
app/controllers/tasks_controller.rb Show resolved Hide resolved
spec/requests/tasks/user_edits_task_request_spec.rb Outdated Show resolved Hide resolved
spec/system/tasks/user_views_task_details_spec.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@fredericomozzato fredericomozzato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sugeri algumas mudanças, mas acho que nada que impeça o código de ser mergeado!

app/controllers/tasks_controller.rb Outdated Show resolved Hide resolved
app/controllers/tasks_controller.rb Show resolved Hide resolved
app/controllers/tasks_controller.rb Outdated Show resolved Hide resolved
config/routes.rb Outdated Show resolved Hide resolved
spec/models/project_spec.rb Outdated Show resolved Hide resolved
spec/models/project_spec.rb Outdated Show resolved Hide resolved
spec/system/tasks/user_views_task_details_spec.rb Outdated Show resolved Hide resolved
decoporteira and others added 5 commits February 7, 2024 09:26
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
decoporteira and others added 5 commits February 7, 2024 10:15
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
…an_edit_task

Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
…de Tasks.

Co-authored-by: Adoniran France <adoniranfranceh@users.noreply.github.com>
@decoporteira decoporteira merged commit 5e62169 into main Feb 7, 2024
@valerialrc valerialrc linked an issue Feb 10, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tarefas] Autorização de acesso [Tarefa] Adiciona user_role_id em Tarefas
5 participants