-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import SLRT support for secure launch #13
Conversation
sinit_acm_base -> dce_base sinit_acm_size -> dce_size "sinit_acm" is Intel-specific. DCE stands for Dynamic Configuration Environment and ACM is considered to be a DCE. Signed-off-by: Ross Philipson <ross.philipson@oracle.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some comments. Most of them are hints for the next steps in separate PRs, but there are some typos and NULL check that should probably be addressed here.
366d53c
to
5643097
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't squash commits yet so it's easier to see differences. See https://github.com/TrenchBoot/grub/compare/366d53cf8f4cb9af5aa01508ded0564b5357f70d..f18f1e3be for changes in top commit and d6d6a8d with 5643097 for larger changes.
There are no more gaps or fixed size of policy entries. Things are added to the list dynamically from different places. This required making callers of grub_txt_boot_prepare()
responsible for finishing building SLRT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the comments are for different addresses before and after relocator, some of them were already present in the previous phase.
5643097
to
d87efc0
Compare
Provide definitions of structures and basic functions for constructing and parsing of SLRT. Signed-off-by: Ross Philipson <ross.philipson@oracle.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
d87efc0
to
d45cdd1
Compare
Signed-off-by: Ross Philipson <ross.philipson@oracle.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
d45cdd1
to
d77df30
Compare
This addresses TrenchBoot/trenchboot-issues#17
Commits were cherry-picked according to TrenchBoot/trenchboot-issues#17 (comment) with minor modifications where necessary (bugs, typos, compilation warnings/errors).
grub-sl-fc-38-dlstub
contains several more patches related to code reorganization and EFI, these were not included.The changes weren't tested.