Skip to content

Commit

Permalink
fix(split-button): fix event bubbling for buttons inside split button
Browse files Browse the repository at this point in the history
  • Loading branch information
ozkersemih committed Jun 3, 2024
1 parent 5e4ef0e commit b0ba8d4
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions src/components/split-button/bl-split-button.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { event, EventDispatcher } from "../../utilities/event";
import "../button/bl-button";
import { TargetType } from "../button/bl-button";
import { ButtonSize, ButtonVariant, ButtonKind } from "../button/bl-button";
import BlButton from "../button/bl-button";
import BlDropdownItem, { blDropdownItemTag } from "../dropdown/item/bl-dropdown-item";
import { BaklavaIcon } from "../icon/icon-list";
import BlPopover from "../popover/bl-popover";
Expand All @@ -29,6 +30,12 @@ export default class BlSplitButton extends LitElement {
@query("bl-popover")
private _popover: BlPopover;

@query("#split-main-button")
private mainButton: BlButton;

@query("#dropdown-button")
private dropdownButton: BlButton;

@state() private _isPopoverOpen = false;

/**
Expand Down Expand Up @@ -145,6 +152,8 @@ export default class BlSplitButton extends LitElement {
firstUpdated() {
// To ensure proper rendering, we set `_popover.target` after the template has been created.
this._popover.target = this.trigger;
this.dropdownButton.addEventListener("bl-click", e => e.stopPropagation());
this.mainButton.addEventListener("bl-click", e => e.stopPropagation());
}

get opened() {
Expand Down

0 comments on commit b0ba8d4

Please sign in to comment.