feat(input): implement password type to input #381
Conversation
|
Thanks for the contribution @AykutSarac ! Please update tests to cover new functionality. |
|
@muratcorlu Done! Let me know if anything is missing. |
|
Apparently, Microsoft Edge has its own password reveal button by default. We may consider hiding it for the consistency https://learn.microsoft.com/en-us/microsoft-edge/web-platform/password-reveal |
There was a problem hiding this comment.
I also realized that, current implementation can have issues with the buttons placed by password managers (like icloud keychain or 1password) To avoid this, I think we need to put icons next to the input instead of putting it on top of input with absolute positioning. But this will need a bigger refactor on the component because currently we use internal input for the borders of the component. Probably we'll need to wrap internal input with another element and handle positioning icons in it.
* disabled style fixed * small size added * vertical alignments fixed * internal component structure refactored for creating extra flexibility for upcoming features (like trailing/leading text), better reliability and maintainability
|
@AykutSarac I opened a PR (#389) that proposes some refactor on Input component. Those changes can help about some stuff in this PR (like avoiding covering password manager buttons with password hide/show buttons). Please have a look at it. Please feel free to reach me with any questions. |
Co-authored-by: Murat Çorlu <127687+muratcorlu@users.noreply.github.com> Signed-off-by: Aykut Saraç <aykutsarac0@gmail.com>
|
Updated accordingly, fyi @muratcorlu. |
|
Great work! We can use neutral kind icon button to open and close the eye like in the design (2nd image) in every input state (default, focused, typing, entered and error). This is because when we use the danger button for the eye in case of error it looks dangerous to press but it is not. @AykutSarac @muratcorlu 1 |
|
Oh, good catch @buseselvi is it ok to use natural color in every case? Including focus state. |
|
🎉 This PR is included in version 2.0.0-beta.66 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Added
passwordtype for bl-input, added toggle action for text visibility.Additionally, closes #302