Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): disabled style and small size fixes #389

Merged
merged 10 commits into from
Jan 27, 2023
Merged

fix(input): disabled style and small size fixes #389

merged 10 commits into from
Jan 27, 2023

Conversation

muratcorlu
Copy link
Contributor

@muratcorlu muratcorlu commented Jan 25, 2023 •
edited
Loading

This PR fixes various issues in input component

  • Disabled style for input fixed
  • Small size added
  • Vertical alignments fixed
  • Internal component structure refactored for creating extra flexibility for upcoming features (like Add suffix and prefix to input #388), better reliability and maintainability
  • A sizing issue in Safari for icon component fixed
  • Handling of long labels those doesn't fit the input
  • Caption font-size fixed (it's 10px in design but it was 12px in our default.css)
  • Input padding was 1px off comparing to design
  • Input padding was wrong on iPad, fixed

Fixes #387
Closes #374

@muratcorlu
fix(icon): safari overflow issue fixed
d32e974
@muratcorlu
fix(input): various visual fixes for input
50b7842 
* disabled style fixed
* small size added
* vertical alignments fixed
* internal component structure refactored for creating extra flexibility
for upcoming features (like trailing/leading text), better reliability and
maintainability
@muratcorlu muratcorlu linked an issue Jan 25, 2023 that may be closed by this pull request
Input disabled style is wrong #387
Closed
@muratcorlu muratcorlu changed the title fix(icon): safari overflow issue fixed fix(input): disabled style and small size fixes Jan 25, 2023
@muratcorlu muratcorlu mentioned this pull request Jan 25, 2023
Merged
@muratcorlu muratcorlu mentioned this pull request Jan 26, 2023
Closed
@muratcorlu
Copy link
Contributor Author

@buseselvi I noticed that the padding of input content was 1px off. I fixed it. Also, the paddings were wrong on iPad, that's fixed too. Please have a look.

@muratcorlu muratcorlu merged commit bd50362 into next Jan 27, 2023
@muratcorlu muratcorlu deleted the 387-input-disabled-style-is-wrong branch January 27, 2023 10:28
@github-actions
Copy link

🎉 This PR is included in version 2.0.0-beta.64 🎉

The release is available on:

Your semantic-release bot 📦🚀

@muratcorlu muratcorlu mentioned this pull request Feb 7, 2023
Closed
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamlaDemir DamlaDemir DamlaDemir approved these changes

@buseselvi buseselvi buseselvi approved these changes

@leventozen leventozen Awaiting requested review from leventozen

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input disabled style is wrong Adding small size for Input Component
3 participants
@muratcorlu @DamlaDemir @buseselvi