Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer has delay for removing from dom #536

Closed
ozkersemih opened this issue Apr 19, 2023 · 3 comments · Fixed by #875
Closed

Drawer has delay for removing from dom #536

ozkersemih opened this issue Apr 19, 2023 · 3 comments · Fixed by #875
Assignees
Labels
bl-drawer Issues related with drawer component released on @beta released

Comments

@ozkersemih
Copy link
Contributor

ozkersemih commented Apr 19, 2023

Description
When user closes drawer, there is 1000ms delay for animation. This also causes delay for removing operation from dom. We can solve it with check animation ended or not with more suitable method.

Expected behavior
We should not use timeout when we remove component from dom. We should check with function.
Screenshots
image
Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]
@muratcorlu
Copy link
Contributor

Maybe it's better to mention what problem that causes: If the user opens a drawer with an embed-url (so with an iframe) and navigate in iframe, then close drawer and open it again in 1 seconds, drawer opens with the previous state (same url in iframe as left) instead of initial url of the iframe.

So, basically, the main problem is not the timeout (because we put it for waiting the slide-out animation) but this affects iframe navigation inside.

Let's consider this bug in this context.

Copy link

github-actions bot commented Jun 3, 2024

🎉 This issue has been resolved in version 3.0.0-beta.22 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This issue has been resolved in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bl-drawer Issues related with drawer component released on @beta released
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants