Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog content scroll shadow should be visible only if content scrollable on that side #624

Closed
2 tasks
muratcorlu opened this issue Jun 9, 2023 · 3 comments · Fixed by #809
Closed
2 tasks

Dialog content scroll shadow should be visible only if content scrollable on that side #624

muratcorlu opened this issue Jun 9, 2023 · 3 comments · Fixed by #809
Assignees
@agursoyy
Labels
bl-dialog Issues related with Dialog component released on @beta released

Comments

@muratcorlu
Copy link
Contributor

In our dialog component, if content is overflows, we show shadow at the bottom. After having #604 merged, we had some discussions with @buseselvi about how it should work. According to those discussions some tunings needed about how it should work:

  • Shadow should be hidden when scroll ends.
  • Same style of shadow should be applied to the top of the content as well.
@muratcorlu muratcorlu added the bl-dialog Issues related with Dialog component label Jun 9, 2023
@muratcorlu muratcorlu mentioned this issue Jun 12, 2023
Closed
@muratcorlu muratcorlu mentioned this issue Jul 11, 2023
Open
1 task
agursoyy pushed a commit to agursoyy/baklava that referenced this issue Mar 7, 2024
fix(dialog): remove shadow from footer when scroll hits bottom
d1a39b5 
Closes Trendyol#624
@agursoyy agursoyy mentioned this issue Mar 7, 2024
Closed
@agursoyy
Copy link
Contributor

agursoyy commented Mar 7, 2024 •
edited
Loading

Screenshot 2024-03-07 at 20 52 46

It does not seem appropriate to add a shadow to the header in the current spacing structure, what do you think?

agursoyy pushed a commit that referenced this issue Mar 8, 2024
fix(dialog): remove shadow from footer when scroll hits bottom
77a4c79 
Closes #624
@agursoyy agursoyy mentioned this issue Mar 8, 2024
Merged
@agursoyy agursoyy self-assigned this Mar 12, 2024
erbilnas added a commit that referenced this issue Mar 18, 2024
@agursoyy @erbilnas
fix(dialog): remove shadow from footer when scroll hits bottom (#809)
ae0cffd 
This PR removes box-shadow from the footer when scrolling to the end of
the content.

Closes #624

Co-authored-by: Alptekin Gursoy <alptekin.gursoy@trendyol.com>
Co-authored-by: Erbil <erbilnas071@gmail.com>
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 3.0.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agursoyy agursoyy

Labels
bl-dialog Issues related with Dialog component released on @beta released
Projects
Baklava Design System
Archived in project
Milestone
No milestone
2 participants
@muratcorlu @agursoyy