Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Tooltip trigger issue #801

Closed
1 task
agursoyy opened this issue Feb 19, 2024 · 2 comments · Fixed by #871
Closed
1 task

[BUG]: Tooltip trigger issue #801

agursoyy opened this issue Feb 19, 2024 · 2 comments · Fixed by #871
Assignees
Labels

Comments

@agursoyy
Copy link
Contributor

agursoyy commented Feb 19, 2024

Issue description

There are two issues noticed in tooltip component;

  • When trigger-element contains an svg icon (or any other element in a different tag), that element cause popover to hide on hover (example).
  • When trigger-element is focusable (input, button etc.), popover is hidden on focus. if you mouse leave and hover/click again, tooltip remains visible. This behavior is inconsistent (example).

It seems that _handlePopoverShowEvent leads this issue because show method of tooltip is triggered even though popover is already open. Adding a visibility condition to show method of tooltip may resolve the issues.
When tried out old versions of tooltip (before popover implementation), it is observed these situations do not occur.

Media & Screenshots

No response

Baklava Version

3.0.0

Operating system

  • OS: [e.g. iOS]:

  • Browser [e.g. chrome, safari]:

  • Any other details...

Priority this issue should have

Low (slightly annoying)

Please review the checkboxes that are applicable.

  • This issue is directly related to React
@agursoyy agursoyy added the bug Something isn't working label Feb 19, 2024
@fatihkucuktry fatihkucuktry self-assigned this Apr 5, 2024
@fatihkucuktry fatihkucuktry removed their assignment Apr 15, 2024
@MertOzbudak MertOzbudak self-assigned this May 14, 2024
buseselvi pushed a commit that referenced this issue May 16, 2024
Nested popover cause this issue, I added tagname control in
_handlePopoverShowEvent to prevent unnecessary hide for bl-tooltip

closes #801

Co-authored-by: mert.ozbudak <mert.ozbudak@trendyol.com>
Copy link

🎉 This issue has been resolved in version 3.0.0-beta.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This issue has been resolved in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants