-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tab component #160
feat: tab component #160
Conversation
# Conflicts: # src/baklava.ts
…tected prop in tab
@buseselvi I think PR is ready for design review. 😊 Can you have a look? |
@mehmetranas I just noticed that |
Can we update the tab titles to "Sub Title 2 Medium" as in the design? It looks like Sub Title 2 Regular. Except those, it looks great! 🥳 |
@muratcorlu We remove the title attribute. Now user can set the title in a slot. |
@buseselvi We fixed all of them. Just not sure about |
@mehmetranas You also need to update stories of |
@mehmetranas yes it should be Sub Title 3 Medium, right 🥲🙏🏻 |
Kudos, SonarCloud Quality Gate passed! |
🎉 This PR is included in version 2.0.0-beta.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.