New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate type declarations for build #278

Merged

olkeoguz merged 5 commits into next from 272-type-declarations-for-build

Oct 13, 2022

Contributor

olkeoguz commented Oct 12, 2022 •

edited

Loading

Includes:

Generating the types with tsc,
Fixing the generate-react-exports.js by including all the component type imports and hooking up the component with its types to the "createComponent" function provided by @lit-labs/react
Updating the docs for the beta version.

Closes #272.

olkeoguz added 3 commits

October 12, 2022 11:15


chore: generate types in build including for react

9d90369


fix: move baklava-react imports to the page top

2cbb491


docs: add warning for beta version

1faee3e

olkeoguz requested review from muratcorlu and leventozen

October 12, 2022 14:45

muratcorlu suggested changes

View reviewed changes

scripts/generate-react-exports.js Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

olkeoguz added 2 commits

October 13, 2022 13:20


fix: change component imports with types

d2d2dee


Merge branch 'next' into 272-type-declarations-for-build

de80c83

sonarcloud bot commented Oct 13, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

olkeoguz requested a review from muratcorlu

October 13, 2022 10:47

muratcorlu approved these changes

View reviewed changes

leventozen approved these changes

View reviewed changes

olkeoguz merged commit f512623 into next

olkeoguz deleted the 272-type-declarations-for-build branch

October 13, 2022 12:55

github-actions bot commented Apr 6, 2023

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment