feat: radio component #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
olkeoguz
reviewed
Nov 14, 2022
olkeoguz
approved these changes
Nov 15, 2022
|
Kudos, SonarCloud Quality Gate passed! |
buseselvi
approved these changes
Nov 16, 2022
|
There is a problem about interaction tests in Chromatic. I created a separate issue for that. I'll merge this component without focus state screenshot test(@buseselvi tested it on storybook manually, it works anyway) to not block this component for a long time. |
|
🎉 This PR is included in version 2.0.0-beta.43 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on unit tests, I wanted to share my work on radio input component.
We decided to use
bl-radioandbl-radio-optioncomponents in #135 but while on development, I noticed that a grouping component will be also needed forcheckboxcomponent andbl-checkbox-optioninside abl-checkboxcomponent didn't look a good naming to me. Becausebl-checkboxcan be used by itself without grouping a list of option (like toggling a single value). So for that kind of casesbl-checkboxname would be a simpler usage (like we already have now).If you also find logical, I'll update issue definition regarding to this and complete this PR by finishing missing parts.
Closes #135