Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on unit tests, I wanted to share my work on radio input component.
We decided to use
bl-radio
andbl-radio-option
components in #135 but while on development, I noticed that a grouping component will be also needed forcheckbox
component andbl-checkbox-option
inside abl-checkbox
component didn't look a good naming to me. Becausebl-checkbox
can be used by itself without grouping a list of option (like toggling a single value). So for that kind of casesbl-checkbox
name would be a simpler usage (like we already have now).If you also find logical, I'll update issue definition regarding to this and complete this PR by finishing missing parts.
Closes #135