Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dialog): add polyfilled property for setting native or polyfill #633

Merged
merged 3 commits into from
Jun 16, 2023

Conversation

Enes5519
Copy link
Contributor

@Enes5519 Enes5519 commented Jun 15, 2023

A prop has been developed that we can set to use native or polyfill. The fastest solution for managing stacking context in browsers without Popover API.

Fixes #617

@Enes5519 Enes5519 requested a review from muratcorlu June 15, 2023 10:47
src/components/dialog/bl-dialog.ts Outdated Show resolved Hide resolved
src/components/dialog/bl-dialog.ts Outdated Show resolved Hide resolved
@muratcorlu muratcorlu changed the title feat(dialog): add levelled property for setting native or polyfill feat(dialog): add polyfilled property for setting native or polyfill Jun 16, 2023
Copy link
Contributor

@muratcorlu muratcorlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are good to go with this for now. When we solve this issue within our popover component (with Popover API), we may deprecate this property in upcoming major releases.

@muratcorlu muratcorlu merged commit 5d6c6b2 into next Jun 16, 2023
@muratcorlu muratcorlu deleted the dialog-levelled-property branch June 16, 2023 11:49
@github-actions
Copy link

🎉 This PR is included in version 2.2.0-beta.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@muratcorlu muratcorlu mentioned this pull request Jul 14, 2023
@github-actions
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toast messages are hiding under dialog backdrop
2 participants