feat(select): implement select all

[ogunb]

Closes #520

[leventozen]

Hey @ogunb, have you had the opportunity to check the performance and usability with a large number of options? I previously commented on this issue in our discussion about the select component problem we experienced more recently. You can find my comment in another PR here.

[ogunb]

Sorry for the late reply, haven't had much time. Here 1000 items:

I don't think we need any big refactors in this task.

Feel free to suggest improvements though.

---

Also I realized clear all button removes disabled options. Is this intended? Should it stay that way? @buseselvi

[buseselvi]

@ogunb If there is a selected disabled option, clear all shouldn't clear them. Can we fix this here? Thank you for noticing. 🙏🏻

[leventozen]

Sorry for the late reply, haven't had much time. Here 1000 items:

I don't think we need any big refactors in this task.

Feel free to suggest improvements though.

Also I realized clear all button removes disabled options. Is this intended? Should it stay that way? @buseselvi

Looks good imo but let's add one more check. Since we don't have any demo projects on hand right now, we can ask for @AykutSarac to test it in his existing project before merging.

[AykutSarac]

Looks good imo but let's add one more check. Since we don't have any demo projects on hand right now, we can ask for @AykutSarac to test it in his existing project before merging.

Works fine at our project.

[buseselvi]

Good job! 🚀 I have a few notes:

• Can we make the "Select All" title the same font size as other titles in Storybook?
• And I think it would be good to add another example to Storybook without the disabled option.
• Also, yesterday at the meeting we noticed a small bug, when we clicked twice to select all, the checkbox changes like in the image below, can we fix it? 🙏🏻 @ogunb

[github-actions]

🎉 This PR is included in version 2.4.0-beta.5 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀