Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

956 feedback implementation #958

Closed
wants to merge 8 commits into from
Closed

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    163f188 View commit details
    Browse the repository at this point in the history
  2. feat(rtl-support): trigger beta release (#937)

    Co-authored-by: Erbil Nas <erbil.nas@trendyol.com>
    erbilnas and Erbil Nas authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    9bcc33e View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. feat(switch): update cursor style to not-allowed when disabled (#943)

    This PR updates the cursor style of the Switch component to
    `not-allowed` when it is disabled, improving user experience by
    indicating that the component is not interactive in its disabled state.
    
    ### Changes
    - Added the following CSS rule to the Switch component:
      ```css
      :host([disabled]) .switch {
        opacity: 0.5;
        cursor: not-allowed; /* added this part */
      }
    ### Issue Resolved
     this PR resolves #942
    
    Co-authored-by: Buse Selvi <106681486+buseselvi@users.noreply.github.com>
    mryunt02 and buseselvi authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    9b9fa6c View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. feat(calendar): Enhance accessibility by adding visually hidden text … (

    #940)
    
    ### Changes
    - Added visually hidden text to the navigation buttons for improved
    accessibility:
    - `<span class="visually-hidden">Previous Calendar View</span>` was
    added to the previous button.
    - `<span class="visually-hidden">Next Calendar View</span>` was added to
    the next button.
    
    ### CSS
    - Added the following CSS class to hide the text visually while keeping
    it accessible to screen readers:
      ```css
      .visually-hidden {
        position: absolute;
        width: 1px;
        height: 1px;
        margin: -1px;
        padding: 0;
        overflow: hidden;
        clip: rect(0, 0, 0, 0);
        border: 0;
      }
    ### Related Issue
    Fixes #939
    
    ---------
    
    Co-authored-by: Erbil <erbilnas071@gmail.com>
    mryunt02 and erbilnas authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    aacd375 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. chore(input): improve type-safety (#954)

    improves type safety for
    * input
    * icon
    AykutSarac authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    460ae3a View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. feat(dialog, drawer, progress-indicator): Add accessibility labels to… (

    #949)
    
    Add accessibility labels to close buttons of dialog and drawer component
    and also aria-label added to progress indicator
    ### Changes 
    
    - Added a label to the close button in the dialog component for better
    accessibility.
    - Added a label to the close button in the drawer component for better
    accessibility.
    - Added aria-label to the progress indicator component for better
    accessibility.
    
    Co-authored-by: Erbil <erbilnas071@gmail.com>
    mryunt02 and erbilnas authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c686e21 View commit details
    Browse the repository at this point in the history
  2. feat(checkbox): Add keyboard handling for Enter and Space keys to tog… (

    #946)
    
    ### Summary of Changes
    - Added keyboard functionality to the input component to toggle the
    checked state when the Enter or Space key is pressed.
    ### Changes Made
    1. Implemented the handleKeyDown function:
    ```
    private handleKeyDown(event: KeyboardEvent) {
        if (event.code === "Enter" || event.code === "Space") {
            this.checked = !this.checked;
            this.onChange(this.checked);
            event.preventDefault();
        }
    }
    
    ```
    2. Associated the function with the @keydown event listener:
    `<input @keydown=${this.handleKeyDown} />`
    
    ### Reason for Changes
    This change was made to enhance user interaction with form elements via
    the keyboard and to improve accessibility.
    
    ---------
    
    Co-authored-by: Buse Selvi <106681486+buseselvi@users.noreply.github.com>
    Co-authored-by: Erbil <erbilnas071@gmail.com>
    3 people authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    dd096eb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    39d09bb View commit details
    Browse the repository at this point in the history