Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of storybook #99

Merged
merged 8 commits into from
Apr 28, 2022
Merged

Conversation

muratcorlu
Copy link
Contributor

@muratcorlu muratcorlu commented Apr 8, 2022

  • Component story format converted to mdx. This way component stories are much simpler and clearer.
  • Some example documents added for the design system. I used built-in components that Stroybook provides for Color Palette, Typography and Iconography.
  • Simplified Storybook configuration and dependencies.
  • Some example stories added for gr-button component.

I'm working on fixing those:

  • Boolean attributes are having empty string values in code examples. Like <gr-button block="">Save</gr-button> It should be same as we write in story file (<gr-button block>Save</gr-button>)
  • styles property of components are visible in auto-generated reference list. It should not mentioned in that list.
  • Editable property list should be visible in Canvas tab to play with properties.
  • Accessibility plugin is not visible.

Closes #78

@muratcorlu muratcorlu linked an issue Apr 8, 2022 that may be closed by this pull request
6 tasks
@muratcorlu muratcorlu marked this pull request as ready for review April 26, 2022 11:34
@muratcorlu
Copy link
Contributor Author

  • Boolean attributes are having empty string values in code examples. Like <gr-button block="">Save</gr-button> It should be same as we write in story file (<gr-button block>Save</gr-button>)

I couldn't find a solution for this item. I mentioned this issue in multiple slack workspaces that I'm involved but couldn't reveice any suggestion. Also asked on StackOverflow. No answer yet.

@muratcorlu muratcorlu linked an issue Apr 26, 2022 that may be closed by this pull request
@muratcorlu muratcorlu removed a link to an issue Apr 28, 2022
@muratcorlu
Copy link
Contributor Author

I'm merging this without a solution for code example issues. We'll check that topic again soon.

@muratcorlu muratcorlu merged commit c868d62 into next Apr 28, 2022
@muratcorlu muratcorlu deleted the 78-implementation-of-storybook branch April 28, 2022 06:48
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of storybook
2 participants