Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get auto-commit , manuel commit options from config #27

Closed
MehmetFiratKomurcu opened this issue Nov 21, 2023 · 1 comment
Closed

Get auto-commit , manuel commit options from config #27

MehmetFiratKomurcu opened this issue Nov 21, 2023 · 1 comment

Comments

@MehmetFiratKomurcu
Copy link
Collaborator

right now, we are manually committing our consumers in order to guarantee committing one time, but for performance we can give option to auto commit as well.
ahmetfurkankavraz pushed a commit to ahmetfurkankavraz/kafka-retry-job that referenced this issue Dec 15, 2023
Trendyol#27 add EnableAutoCommit flag to enable auto commit strategy
9ebb5b1
ahmetfurkankavraz pushed a commit to ahmetfurkankavraz/kafka-retry-job that referenced this issue Dec 26, 2023
Trendyol#27 fixes the config files of Kafka ConsumerConfig and adds c…
8104ca3 
…onfigs to the read me file
MehmetFiratKomurcu added a commit that referenced this issue Dec 28, 2023
@MehmetFiratKomurcu
Merge pull request #28 from ahmetfurkankavraz/main
7913141 
Pull Request for the issues #18 #24 #25 #27
@MehmetFiratKomurcu
Copy link
Collaborator Author

done with #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MehmetFiratKomurcu