Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Acks to ProducerConfig if exists in configuration as ProducerAcks #36

Closed
MehmetFiratKomurcu opened this issue Feb 8, 2024 · 0 comments
Closed

Add Acks to ProducerConfig if exists in configuration as ProducerAcks #36

MehmetFiratKomurcu opened this issue Feb 8, 2024 · 0 comments
Assignees
@ElifBayrakdar
Labels
bug Something isn't working

Comments

@MehmetFiratKomurcu
Copy link
Collaborator

MehmetFiratKomurcu commented Feb 8, 2024 •
edited by ElifBayrakdar
Loading

this is a bug for version 1.12.0,
We have ProducerEnableIdempotence configuration with default value true. And also we have ProducerAcks configuration with default value Leader. When ProducerEnableIdempotence is true, ProducerAcks can not be Leader.
@MehmetFiratKomurcu MehmetFiratKomurcu added the bug Something isn't working label Feb 8, 2024
@ElifBayrakdar ElifBayrakdar self-assigned this Feb 8, 2024
@ElifBayrakdar ElifBayrakdar changed the title Set Producer Acks config default Leader Add Acks to ProducerConfig if exists in configuration as ProducerAcks Feb 9, 2024
ElifBayrakdar pushed a commit to ElifBayrakdar/kafka-retry-job that referenced this issue Feb 9, 2024
Trendyol#36 Add Acks to ProducerConfig if exists in configuration as …
d6e68f8 
…ProducerAcks
ElifBayrakdar pushed a commit to ElifBayrakdar/kafka-retry-job that referenced this issue Feb 9, 2024
Trendyol#36 Edit CHANGELOG.MD
affca85
MehmetFiratKomurcu added a commit that referenced this issue Feb 9, 2024
@MehmetFiratKomurcu
Merge pull request #37 from ElifBayrakdar/feature/issue-36
d49097c 
#36 Add Acks to ProducerConfig if exists in configuration as Producer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElifBayrakdar ElifBayrakdar

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ElifBayrakdar @MehmetFiratKomurcu