Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the quarkus starter work again with quarkus 3.x.x #109

Merged
merged 1 commit into from
May 8, 2023

Conversation

lucas-dclrcq
Copy link
Contributor

Since quarkus 3.0.0 javax. packages were renamed to the jakarta. packages.

This aligns all imports so the quarkus starter works again :)

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.51 ⚠️

Comparison is base (72c46e7) 69.03% compared to head (fab90fa) 68.52%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #109      +/-   ##
============================================
- Coverage     69.03%   68.52%   -0.51%     
  Complexity       49       49              
============================================
  Files            17       17              
  Lines           197      197              
  Branches          6        6              
============================================
- Hits            136      135       -1     
- Misses           58       59       +1     
  Partials          3        3              
Flag Coverage Δ
unittests 68.52% <ø> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...om/trendyol/kediatr/quarkus/KediatRBeanProvider.kt 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@osoykan
Copy link
Collaborator

osoykan commented May 8, 2023

Hi @lucas-dclrcq,

Thanks a lot for the contribution!

@osoykan osoykan merged commit 11defb3 into Trendyol:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants