Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to invoke publish method with custom publishStrategy #92

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

awaniak
Copy link
Contributor

@awaniak awaniak commented Apr 11, 2023

Issue #88

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.35 ⚠️

Comparison is base (b103192) 68.87% compared to head (356aecb) 68.52%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
- Coverage     68.87%   68.52%   -0.35%     
- Complexity       48       49       +1     
============================================
  Files            17       17              
  Lines           196      197       +1     
  Branches          6        6              
============================================
  Hits            135      135              
- Misses           58       59       +1     
  Partials          3        3              
Flag Coverage Δ
unittests 68.52% <100.00%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/kotlin/com/trendyol/kediatr/MediatorBuilder.kt 100.00% <100.00%> (ø)
...c/main/kotlin/com/trendyol/kediatr/MediatorImpl.kt 96.66% <100.00%> (+0.11%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@osoykan osoykan self-requested a review April 12, 2023 09:39
Copy link
Collaborator

@osoykan osoykan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@osoykan osoykan merged commit 21ef304 into Trendyol:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants