Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YamlCreate does not handle manifest-level parameters #30

Closed
Trenly opened this issue Sep 17, 2021 · 1 comment · Fixed by #34
Closed

YamlCreate does not handle manifest-level parameters #30

Trenly opened this issue Sep 17, 2021 · 1 comment · Fixed by #34
Labels
Bug Something isn't working

Comments

@Trenly
Copy link
Owner

Trenly commented Sep 17, 2021

Brief description of your issue

Some manifests define installer parameters at the manifest level instead of at the installer level. YamlCreate is unable to properly handle these

Expected behavior

Manifest level parameters should be parsed properly

Proposed solution

When parameters are defined at the manifest level, reading of the previous installer manifest should remove them from the manifest level and add them to every installer at the installer level. This will allow for #29 to be more robust in the event any updates are made to installers which would make these parameters unable to be defined at the manifest level after update

@Trenly Trenly added the Bug Something isn't working label Sep 17, 2021
@Trenly
Copy link
Owner Author

Trenly commented Sep 18, 2021

Upon further review; This should also include a refactoring of the script to update the manifests in-place where applicable, instead of always creating new ones.

Logic Flow:

------------------------------
During read previous flow
------------------------------
If old singleton manifest exists
> Create new empty multi-manifest
> Copy existing fields from singleton into the appropriate multi-manifest file

If old multi-manifest exists
> Set new installer manifest equal to existing installer manifest
> Set new locale manifest equal to existing locale manifest
> Set new version manifest equal to old locale manifest

If no manifests exist
> Create new empty manifests

------------------------------
During data entry flow
------------------------------
For any new required entries
> Set the appropriate Manifest['Key'] value directly instead of using script variables

For any optional values
> If the value entered is null or empty, do not update the field
> If the value entered is not null and is valid, update the value in place

------------------------------
During file creation flow
------------------------------
Directly use the new manifests which were updated in-place 
Re-Sort the keys to ensure accuracy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant