forked from microsoft/winget-pkgs
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YamlCreate does not handle manifest-level parameters #30
Labels
Bug
Something isn't working
Comments
Upon further review; This should also include a refactoring of the script to update the manifests in-place where applicable, instead of always creating new ones. Logic Flow:
|
This was referenced Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Brief description of your issue
Some manifests define installer parameters at the manifest level instead of at the installer level. YamlCreate is unable to properly handle these
Expected behavior
Manifest level parameters should be parsed properly
Proposed solution
When parameters are defined at the manifest level, reading of the previous installer manifest should remove them from the manifest level and add them to every installer at the installer level. This will allow for #29 to be more robust in the event any updates are made to installers which would make these parameters unable to be defined at the manifest level after update
The text was updated successfully, but these errors were encountered: