Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of the script to update the manifests in-place where applicable #37

Open
Trenly opened this issue Sep 20, 2021 · 0 comments

Comments

@Trenly
Copy link
Owner

Trenly commented Sep 20, 2021

Upon further review; This should also include a refactoring of the script to update the manifests in-place where applicable, instead of always creating new ones.

Logic Flow:

------------------------------
During read previous flow
------------------------------
If old singleton manifest exists
> Create new empty multi-manifest
> Copy existing fields from singleton into the appropriate multi-manifest file

If old multi-manifest exists
> Set new installer manifest equal to existing installer manifest
> Set new locale manifest equal to existing locale manifest
> Set new version manifest equal to old locale manifest

If no manifests exist
> Create new empty manifests

------------------------------
During data entry flow
------------------------------
For any new required entries
> Set the appropriate Manifest['Key'] value directly instead of using script variables

For any optional values
> If the value entered is null or empty, do not update the field
> If the value entered is not null and is valid, update the value in place

------------------------------
During file creation flow
------------------------------
Directly use the new manifests which were updated in-place 
Re-Sort the keys to ensure accuracy

Originally posted by @Trenly in #30 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant