feat: backdrop stage abstraction #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cientos-tresjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JaimeTorrealba
requested changes
Jul 3, 2023
There was a problem hiding this comment.
Why do we add models and textures here in cientos?
Should not go in assets repo?
There was a problem hiding this comment.
I though for docs would be ok to have them locally for performance, but seems like that's breaking when statically generating the assets.
There was a problem hiding this comment.
Same here, is there a reason why these textures are here?
Should not go in assets?
|
I check the example in netlify deploy, but I'm not sure if is right. https://deploy-preview-116--cientos-tresjs.netlify.app/guide/staging/backdrop.html
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.