feat(app)!: 227 Change the keyboardcontrols implementation #339

JaimeTorrealba · 2024-01-28T13:44:51Z

Please check the playground, and play with it, lt me know what you think.

closes #227

stackblitz · 2024-01-28T13:44:54Z

Run & review this pull request in StackBlitz Codeflow.

netlify · 2024-01-28T13:44:56Z

Name	Link
🔨 Latest commit	`39e2094`
🔍 Latest deploy log	https://app.netlify.com/sites/cientos-tresjs/deploys/65bed451a96e97000875ea2d
😎 Deploy Preview	https://deploy-preview-339--cientos-tresjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

andretchen0 · 2024-01-30T16:54:59Z

It works well!

I think these would be welcome features:

arrow key support
gradually ramp up to top speed for movement. Maybe implemented using constants like the Three.js example. Or maybe implemented as reactive props: acceleration, friction, maxSpeed.

Maybe: head bob! 🤣

feat(app)!: 227 Change the keyboardcontrols implementation

fed0f86

JaimeTorrealba added the v4 label Jan 28, 2024

JaimeTorrealba requested a review from alvarosabu January 28, 2024 13:44

JaimeTorrealba self-assigned this Jan 28, 2024

JaimeTorrealba marked this pull request as draft January 28, 2024 13:44

feat: add arrow keys support

39e2094

JaimeTorrealba changed the base branch from main to v4 February 9, 2024 13:49

JaimeTorrealba added 2 commits February 23, 2024 21:02

docs(app): 227 Add documentation for new KeyboardControls

4de9f32

feat(app): 227 Final details, ready to go

6f06213

JaimeTorrealba marked this pull request as ready for review February 23, 2024 21:09

refactor: move in the right position a piece of code

7c74b93

JaimeTorrealba merged commit d591632 into v4 Apr 3, 2024
2 checks passed

Provide feedback