-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add component list grid view to /guide #399
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Since the data's not just used for the sidebar anymore, I thought it made sense to move the component list out of I put it into We'll have to change that |
Hi @andretchen0, I like the idea. But when I pull the changes, nothing happen. I need to do some action to be able to see the grid? I checked, I have your changes in local but the view is the same |
@JaimeTorrealba Can you see it if you scroll down? |
Ok, ok now I see, it just in the guide page. Unmm what can we do to improve the UX here? Using the same structure already create. It could be a link below the guide for all component (grid view) or in the navbar next to the search wdyt? Could be a modal with a float button?. |
Yes, sound good |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is ok for now, later we can see how to create the links automatically
Just FYI, there's no repetition of data. Or at least no more than existed prior to this PR.
Is that ok? |
This is incredible useful guys, I really like it |
closes #380
This adds a grid view of the component list to /guide.