docs(app): Improve docs examples with code group to avoid confusion #463

JaimeTorrealba · 2024-08-07T20:51:11Z

No description provided.

…ed is toggled

… to module

…g functions

…n not found

* chore(deps): update deps to latest * chore: on demand invalidation composable with prop change detection * feat: on-demand orbit-controls * feat: on-demand camera controls * feat: invalidate also on autoRotate * feat: on-demand map controls and refactor * feat: on-demand transform controls * feat: on-demand keyboard controls * feat: on-demand keybaord controls * chore: added demo suffix to control pages to avoid confusions * feat: on-demand pointer lock controls * feat: on-demand scroll controls * feat: on-demand levioso * feat: correct orbit controls auto rotate invalidation * feat: on-demand text3d * feat: on-demand mouse-parallax * feat: on-demand fbo and size watcher refactor * chore(playground): refactor to use useLoop and sub components * chore: remove unused import for lint fix * chore(playground): refactor lensflare demo to use useLoop * feat: on-demand sampler * feat: on-demand invaldiation on reflector prop change * chore: added render activity graph and try to make on-demand work on AnimatedSprite * chore: renamed positional audio demo * chore: on-demand smoke * feat: on-demand precipitation * feat: on-dermand stars * feat: on-demand Environment * feat: on-demand sky * feat: on-demand Ocean component * chore: testing on-demand on fit * feat: on-demand Wobble Material * feat: on-demand invalidation holographic material * feat: on-demand reflection material * feat: on-demand custom shader material * chore: rename bakeshadows demo * chore: misc route * chore: ci, update action setup * chore: update Tres core * fix: reimplement ContactShadows for v4 core * docs: change link name * fix(ContactShadows): add invalidate to updates --------- Co-authored-by: alvarosabu <alvaro.saburido@gmail.com>

* feat(Sparkles): invalidate on update * chore: fix linter error * refactor(Sparkles): remove renderMode predicate before invalidate

* chore: remove `useOnDemandInvalidation` on Levioso * chore: remove composable `useOnDemandInvalidation` * chore: remove composable from Ocean * chore: remove composable on Precipitation * chore: remove composable from sky * chore: remove from Fit * chore: remove from smoke * chore: remove from orbit-controls * chore: remove composable from Text3D * chore: remove from mouse parallax * chore: remove composable from Reflector * chore: only needed fbo invalidation * chore: remove composable from useSurfaceSampler * chore: remove composable from all controls * chore: add invalidation on loop * chore: remove prop speed check on loop for Levioso * chore: remove invalidateOnDemand on MapControls * chore: remove `invalidateOnDemand` from Keyboard controls * chore: add invalidate on fit method, remove watch props

This PR adds an `autoRender` flag to `FBOOptions`. This flag allows consumers of `useFBO` who want to take control of when and where to render the render target instead of always rendering it with the default scene and camera. Co-authored-by: Alvaro Saburido <alvaro.saburido@gmail.com>

stackblitz · 2024-08-07T20:51:13Z

Run & review this pull request in StackBlitz Codeflow.

alvarosabu

Great idea @JaimeTorrealba, hopefully this will educate community about async usage on cientos.

I just added minor suggestion on the naming of components.

Thanks for the PR

alvarosabu · 2024-08-12T09:00:00Z

docs/guide/loaders/use-fbx.md

+<script setup lang="ts">
+import { TresCanvas } from '@tresjs/core'
+import { OrbitControls } from '@tresjs/cientos'
+import AsyncComponent from './AsyncComponent.vue'


Suggested change

import AsyncComponent from './AsyncComponent.vue'

import TheModel from './TheModel.vue'

alvarosabu · 2024-08-12T09:00:10Z

docs/guide/loaders/use-fbx.md

+    <TresPerspectiveCamera :position="[11, 11, 11]" />
+    <OrbitControls />
+    <Suspense>
+      <AsyncComponent />


Suggested change

<AsyncComponent />

<TheModel />

alvarosabu · 2024-08-12T09:00:17Z

docs/guide/loaders/use-fbx.md

+  </TresCanvas>
+</template>
+```
+```vue{2,6} [AsyncComponent.vue]


Suggested change

```vue{2,6} [AsyncComponent.vue]

```vue{2,6} [TheModel.vue]

alvarosabu · 2024-08-12T09:00:30Z

docs/guide/loaders/use-gltf.md

+<script setup lang="ts">
+import { TresCanvas } from '@tresjs/core'
+import { OrbitControls } from '@tresjs/cientos'
+import AsyncComponent from './AsyncComponent.vue'


Suggested change

import AsyncComponent from './AsyncComponent.vue'

import TheModel from './TheModel.vue'

alvarosabu · 2024-08-12T09:00:40Z

docs/guide/loaders/use-gltf.md

+    <TresPerspectiveCamera :position="[3, 2, 5]" />
+    <OrbitControls />
+    <Suspense>
+      <AsyncComponent />


Suggested change

<AsyncComponent />

<TheModel />

alvarosabu · 2024-08-12T09:00:53Z

docs/guide/loaders/use-gltf.md

+  </TresCanvas>
+</template>
+```
+```vue{2,6} [AsyncComponent.vue]


Suggested change

```vue{2,6} [AsyncComponent.vue]

```vue{2,6} [TheModel.vue]

alvarosabu · 2024-08-12T09:01:48Z

docs/guide/loaders/use-video-texture.md

+<script setup lang="ts">
+import { TresCanvas } from '@tresjs/core'
+import { OrbitControls } from '@tresjs/cientos'
+import AsyncComponent from './AsyncComponent.vue'


Suggested change

import AsyncComponent from './AsyncComponent.vue'

import TheVideoTexture from './TheVideoTexture.vue'

alvarosabu · 2024-08-12T09:01:54Z

docs/guide/loaders/use-video-texture.md

+    />
+    <OrbitControls />
+    <Suspense>
+      <AsyncComponent />


Suggested change

<AsyncComponent />

<TheVideoTexture />

alvarosabu · 2024-08-12T09:02:03Z

docs/guide/loaders/use-video-texture.md

+  </TresCanvas>
+</template>
+```
+```vue{3,8,13} [AsyncComponent.vue]


Suggested change

```vue{3,8,13} [AsyncComponent.vue]

```vue{3,8,13} [TheVideoTexture.vue]

netlify · 2024-08-24T15:30:37Z

✅ Deploy Preview for cientos-tresjs ready!

Name	Link
🔨 Latest commit	`a217277`
🔍 Latest deploy log	https://app.netlify.com/sites/cientos-tresjs/deploys/66c9fe1e943d850008ad0936
😎 Deploy Preview	https://deploy-preview-463--cientos-tresjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…ync-components

JaimeTorrealba · 2024-08-24T15:38:54Z

@alvarosabu I have fixed this one, please let me know if everything good

andretchen0 and others added 30 commits January 11, 2024 22:31

feat(AnimatedSprite): add AnimatedSprite, playground, docs

d6ea81b

chore(AnimatedSprite): fix linter errors

e7ff5a2

chore(AnimatedSprite): update docs

c74c332

feat(AnimatedSprite): allow [numCols, numRows] as atlas prop

3309d9c

docs(AnimatedSprite): reorder sections, improve clarity

49380ee

docs(AnimatedSprite): format type names

c2bfd63

docs(AnimatedSprite): update no-atlas example to use [cols, rows]

d4a7528

chore(AnimatedSprite): run linter, remove console.log

823c8d7

refactor(AnimatedSprite): create new animation frames if props.revers…

3db5140

…ed is toggled

docs(AtlasAnimationDefinitionParser): change 'delay' to 'duration'

970c91b

refactor(AtlasAnimationDefinitionParser): make parse function private…

fbda429

… to module

refactor(AtlasAnimationDefinitionParser): use destructuring

612c9ba

refactor(AtlasAnimationDefinitionParser): use destructuring

4adc67a

refactor(AtlasAnimationDefinitionParser): rename returned value 'result'

8c586ad

chore: run linter

db74f59

refactor(AtlasAnimationDefinitionParser): rename private error loggin…

0cb9788

…g functions

refactor(Atlas): rename private functions

d45ae6d

fix(Atlas): add missing argument to function call

e6b147e

refactor(AnimatedSprite): merge FrameData types as single type

9481afe

refactor(AnimatedSprite): change callbacks to emits

f2edc12

chore(AnimatedSprite): run linter

1adcc1a

chore(AnimatedSprite): format Atlas error message

6daa414

fix(AnimatedSprite): return nullFrame animation if requested animatio…

453819e

…n not found

refactor(AnimatedSprite): simplify component onLoop

c8f96d7

chore(AnimatedSprite): run lint --fix

2b71c80

refactor(AnimatedSprite): add Atlasish type

6264d13

refactor(AnimatedSprite): remove onLoad prop

d560368

feat(app)!: 227 Change the keyboardcontrols implementation

fed0f86

docs(AnimatedSprite): update docs and demos

6a61810

docs(AnimatedSprite): update playground demo

1467129

andretchen0 and others added 20 commits July 23, 2024 14:34

refactor: call invalidate on props update

ca69747

docs: add on-demand shapes playground demo

1a88ebc

feat(Sparkles): invalidate on update (#446)

cbfd226

* feat(Sparkles): invalidate on update * chore: fix linter error * refactor(Sparkles): remove renderMode predicate before invalidate

chore: invalidation refactor leftovers

cc322f5

chore(types): fixes some type issues

a68ca3a

fix: update to core v4.2.2 to remove warning on invalidation

42afa6e

chore: fix lint

3323cfa

chore: release v4.0.0-rc.0

9b0c95b

chore: fix lint

9283045

chore: release v4.0.0-rc.1

c01903e

docs: added recipe for tweakpane to migration guides

33f820b

chore(playground): added same scale as default

26f6e86

chore: release v4.0.0-rc.2

5bf9d4a

Merge branch 'main' into v4

2d8e57e

chore: linter fix

d118d27

chore: update deps to fix docs build

50facb1

docs(app): Improve docs examples with code group to avoid confusion

4c8fef1

JaimeTorrealba requested review from alvarosabu and andretchen0 August 7, 2024 20:51

alvarosabu requested changes Aug 12, 2024

View reviewed changes

JaimeTorrealba changed the base branch from v4 to main August 24, 2024 15:30

JaimeTorrealba added 2 commits August 24, 2024 16:30

fix: change name to the async components

f5b234a

Merge remote-tracking branch 'origin/main' into docs/code-group-in-as…

a217277

…ync-components

alvarosabu merged commit 38213d7 into main Aug 29, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(app): Improve docs examples with code group to avoid confusion #463

docs(app): Improve docs examples with code group to avoid confusion #463

JaimeTorrealba commented Aug 7, 2024

stackblitz bot commented Aug 7, 2024

alvarosabu left a comment

alvarosabu Aug 12, 2024

alvarosabu Aug 12, 2024

alvarosabu Aug 12, 2024

alvarosabu Aug 12, 2024

alvarosabu Aug 12, 2024

alvarosabu Aug 12, 2024

alvarosabu Aug 12, 2024

alvarosabu Aug 12, 2024

alvarosabu Aug 12, 2024

netlify bot commented Aug 24, 2024 •

edited

Loading

JaimeTorrealba commented Aug 24, 2024

	import AsyncComponent from './AsyncComponent.vue'
	import TheModel from './TheModel.vue'

	import AsyncComponent from './AsyncComponent.vue'
	import TheVideoTexture from './TheVideoTexture.vue'

	```vue{3,8,13} [AsyncComponent.vue]
	```vue{3,8,13} [TheVideoTexture.vue]

docs(app): Improve docs examples with code group to avoid confusion #463

docs(app): Improve docs examples with code group to avoid confusion #463

Conversation

JaimeTorrealba commented Aug 7, 2024

stackblitz bot commented Aug 7, 2024

alvarosabu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

netlify bot commented Aug 24, 2024 • edited Loading

✅ Deploy Preview for cientos-tresjs ready!

JaimeTorrealba commented Aug 24, 2024

netlify bot commented Aug 24, 2024 •

edited

Loading