Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simple editor #110

Merged
merged 3 commits into from
Apr 17, 2024
Merged

feat: simple editor #110

merged 3 commits into from
Apr 17, 2024

Conversation

franciscohermida
Copy link
Contributor

No description provided.

@alvarosabu alvarosabu self-assigned this Apr 9, 2024
JaimeTorrealba
JaimeTorrealba approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@JaimeTorrealba JaimeTorrealba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job, Francisco, I loved it.

Just drop some comments, any of them blocking this PR. Feel free to accept them or reject them.

When you finish, just merge this one or tell me

@andretchen0 andretchen0 mentioned this pull request Apr 15, 2024
Merged
@franciscohermida
Copy link
Contributor Author

@JaimeTorrealba submitted new issue regarding the problem I was having with click event handler Tresjs/tres#649.

Let me know if there is anything else I need to do here.

@JaimeTorrealba JaimeTorrealba merged commit 45fcf95 into Tresjs:main Apr 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaimeTorrealba JaimeTorrealba JaimeTorrealba approved these changes

Assignees

@alvarosabu alvarosabu

Labels
demo showcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franciscohermida @JaimeTorrealba @alvarosabu