fix: Pointer Leave and Out events not being called #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
garrlker
force-pushed
the
bugfix/713-pointer-leave-not-calling
branch
from
ab20621 to
974b1e8
Compare
5 tasks
garrlker
force-pushed
the
bugfix/713-pointer-leave-not-calling
branch
from
974b1e8 to
66264fc
Compare
alvarosabu
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an oversight where we were not using the previous intersection event data for an @pointer-leave/@pointer-out events
That meant when we fired either of those events, typically it was with an empty intersections array, and the events would never get propagated to the object that needed it.
Now they do, and this PR should fix #713