-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): 680 UseTexture composable as component #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alvarosabu
added
p2-nice-to-have
Not breaking anything but nice to have (priority)
feature
labels
Jul 4, 2024
alvarosabu
requested changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the idea but not the execution. We need to be more strict on the standardization of the code base and avoid having 3 different approaches to components.
commit: |
alvarosabu
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #680
Convert a composable like this one, as a component is not difficult, what I would like to know is what do you think about this one
Component Name
Vueuse, use the same name of the composable and seems to have no problem (the component start with uppercase), but what do you think? Could this confuse users? Any other alternatives.
useTexture and UseTexture
Props and result
They share the same name in the example they are :map="map" and the result currently is v-slot="{ map}"
I personally don't see any problem but again I would like to know what do you think?
Docs
I would not do the docs just yet, until your answers. But my idea is to put the docs of this just below the existing composable, any thoughts?