Combine .app-main and #main turbo-frame #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spohlenz
force-pushed
the
main-turbo-frame
branch
from
3c511b2
to
c1a4544
Compare
spohlenz
added a commit
that referenced
this pull request
Sep 24, 2024
…rbo-frame into layout partial
Merged
spohlenz
added a commit
that referenced
this pull request
Sep 26, 2024
* Separate .app-main and #main turbo-frame (reverting #497) but move turbo-frame into layout partial * Remove turbo stream layout in order to apply more granular update behavior * Introduce #content turbo-frame in layout partial and deprecate index_turbo_frame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A separate turbo-frame child element caused issues when elements expect to be within the .app-main flex container.