Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change internal TriBITS target_link_libraries() to PUBLIC (#299) #413

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Change internal TriBITS target_link_libraries() to PUBLIC (#299) #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tribits/core/package_arch/TribitsAddExecutable.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ include(CMakeParseArguments)
# ``TESTONLYLIBS <lib0> <lib1> ...``
#
# Specifies extra test-only libraries defined in this CMake project that
# will be linked to the executable using ``target_link_library()``. Note
# will be linked to the executable using ``target_link_libraries()``. Note
# that regular libraries (i.e. not ``TESTONLY``) defined in the current SE
# package or any upstream SE packages can *NOT* be listed! TriBITS
# automatically links non ``TESTONLY`` libraries in this package and
Expand All @@ -197,7 +197,7 @@ include(CMakeParseArguments)
# ``IMPORTEDLIBS <lib0> <lib1> ...``
#
# Specifies extra external libraries that will be linked to the executable
# using ``target_link_library()``. This can only be used for libraries
# using ``target_link_libraries()``. This can only be used for libraries
# that are built external from this CMake project and are not provided
# through a proper `TriBITS TPL`_. The latter usage of passing in
# external libraries is not recommended. External libraries should be
Expand Down Expand Up @@ -646,7 +646,7 @@ function(tribits_add_executable EXE_NAME)
message("-- ${EXE_NAME}:LINK_LIBS='${LINK_LIBS}'")
endif()

target_link_libraries(${EXE_BINARY_NAME} ${LINK_LIBS})
target_link_libraries(${EXE_BINARY_NAME} PUBLIC ${LINK_LIBS})

assert_defined(${PROJECT_NAME}_LINK_SEARCH_START_STATIC)
if (${PROJECT_NAME}_LINK_SEARCH_START_STATIC)
Expand Down
2 changes: 1 addition & 1 deletion tribits/core/package_arch/TribitsLibraryMacros.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,7 @@ function(tribits_add_library LIBRARY_NAME_IN)
message("-- ${LIBRARY_NAME_IN}:LINK_LIBS='${LINK_LIBS}'")
endif()

target_link_libraries(${LIBRARY_NAME} ${LINK_LIBS})
target_link_libraries(${LIBRARY_NAME} PUBLIC ${LINK_LIBS})

if (${PROJECT_NAME}_CXX_STANDARD_FEATURE)
target_compile_features(${LIBRARY_NAME} PUBLIC "${${PROJECT_NAME}_CXX_STANDARD_FEATURE}")
Expand Down