use FIND_PACKAGE(HDF5) #59
Conversation
|
I just tested this with several versions of Debian and Ubuntu and this patch indeed makes finding the HDF5 libraries more robust. Specifically, TriBits doesn't work for Ubuntu Vivid and beyond since the libraries were slightly renamed here. |
|
Nico, As described in #67, we need to make some changes to the way that updated |
…SPub#59 and TriBITSPub#67) Now it only calls FIND_PACKAGE(HDF5 ...) when TPL_HDF5_INCLUDE_DIRS and TPL_HDF5_LIBRARIES are not set. This skips the find when there is an override. This will avoid some confusion I would think. I also added logic so FIND_PACKAGE(HDF5 ...) will to also find hdf5_fortran when HDF5_REQUIRE_FORTRAN is TRUE. This should match existing behavior perfectly when the user does not set any of the cache vars. The creates a better default find operation. This will get refactored more as part of TriBITS TriBITSPub#59 before it is finished.
…riBITS TriBITSPub#59 and TriBITSPub#67) With this update, FindTPLHDF5.cmake should maintain good backward compatibility but will still call FIND_PACKAGE(HDF5 ...) by default if the user does nothing.
|
Nico, look at the branch If I don't hear from you pretty quick, I will go ahead and push this. |
Now it only calls FIND_PACKAGE(HDF5 ...) when TPL_HDF5_INCLUDE_DIRS and TPL_HDF5_LIBRARIES and other TPL find variables are not set (see TriBITS #67). This skips the find when there is an override. This will avoid some confusion I would think. I also added logic so FIND_PACKAGE(HDF5 ...) will to also find hdf5_fortran when HDF5_REQUIRE_FORTRAN is TRUE. This should match existing behavior perfectly when the user does not set any of the cache vars. The creates a better default find operation. With this update, FindTPLHDF5.cmake should maintain good backward compatibility but will still call FIND_PACKAGE(HDF5 ...) by default if the user does nothing. Win win.
|
Closing this in favor of commit 2e44739. |
No description provided.