Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete subscription not working #64

Closed
windose opened this issue Nov 25, 2022 · 2 comments
Closed

Delete subscription not working #64

windose opened this issue Nov 25, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@windose
Copy link

windose commented Nov 25, 2022

Describe the bug
A clear and concise description of what the bug is.

Have you read the Contributing Guidelines?

Yes

To Reproduce
Steps to reproduce the behavior:

  1. Enable subscriptions in resolver
  2. Subscribe to deletedOne or deletedMany
  3. Trigger a deleteOne or deleteMany mutation

Expected behavior
The subscription should trigger if an object was deleted.

Screenshots
n/a

Desktop (please complete the following information):

  • Node Version: 14.14.0
  • Nestjs-query Version: 1.1.2

Additional context
The other subscriptions, like updated and created are working fine, but deleted not.
@windose windose added the bug Something isn't working label Nov 25, 2022
windose added a commit to windose/nestjs-query that referenced this issue Nov 25, 2022
@windose
fix(graphql,TriPSs#64): fix of delete subscriptions
8b56d21
@windose windose mentioned this issue Nov 25, 2022
Merged
@nxmad
Copy link

nxmad commented Nov 25, 2022

I can confirm this, AuthFilter is lost for delete subscriptions. Mentioned 13 days ago at #45. @TriPSs please merge.

TriPSs added a commit that referenced this issue Nov 25, 2022
@TriPSs
Merge pull request #65 from windose/master
491ef46 
Fix of #64
@TriPSs
Copy link
Owner

TriPSs commented Nov 25, 2022

This is fixed thanks to @windose ❤️ Released in version v1.1.3

@TriPSs TriPSs closed this as completed Nov 25, 2022
@TriPSs TriPSs mentioned this issue Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@windose @nxmad @TriPSs