Reimplement UDP endpoint listener with Twisted DatagramProtocol #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Ok to test |
|
Can one of the admins verify this patch? |
|
Ok to test |
|
Can one of the admins verify this patch? |
|
Ok to test |
qstokkink
requested changes
May 9, 2018
| for _ in xrange(10000): | ||
| try: | ||
| self._listening_port = reactor.listenUDP(self._port, self, self._ip, UDP_MAX_SIZE) | ||
| #self._listening_port.startListening() |
There was a problem hiding this comment.
Why is this commented out code here?
| self._running = False | ||
| result = True | ||
| #FIXME: this thing returns Deferred, need to account for that | ||
| self._listening_port.stopListening() |
There was a problem hiding this comment.
Why not just return this deferred and get rid of the timeout parameter?
|
So I just removed the timeout argument completely. Anyways, it was not used anywhere. |
qstokkink
approved these changes
May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greatly speed-ups everything!
See Tribler/tribler#2548